Conversation
pyth0n1c
reviewed
Jun 5, 2025
| import pathlib | ||
| from typing import List, Union | ||
| from datetime import datetime | ||
| from typing import Any, Dict, List, Set, TypedDict, Union |
Contributor
There was a problem hiding this comment.
Since Python 3.9, it is not recommended to import simple(r) types from typing like list, dict, or set. This should just be used directly. For example instead of
x:List[str]
instead use
x:list[str]
Contributor
There was a problem hiding this comment.
I updated I updated attack_enrichment.py as well along these lines.
…nto TR-3506_mitre_update
syntax. Bump bugfix release in pyproject. Remove pandas requirement, which is not used, from pyproject.toml
pyth0n1c
reviewed
Jun 10, 2025
| name = "contentctl" | ||
|
|
||
| version = "5.5.3" | ||
| version = "5.5.4" |
Contributor
There was a problem hiding this comment.
Bumped patch version in prep for release.
Also, pandas dependency was removed as it is not required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to support latest navigator
5.1.0also leveraging all the new features .. looks much nicer